[libcxx-commits] [PATCH] D111516: [libc++][docs] Mark LWG3274 as complete

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Two small nits, but I'd like to see the CI passing before approving.



================
Comment at: libcxx/include/span:335
     _LIBCPP_INLINE_VISIBILITY constexpr size_type size_bytes() const noexcept { return _Extent * sizeof(element_type); }
-    _LIBCPP_INLINE_VISIBILITY constexpr bool empty()           const noexcept { return _Extent == 0; }
+    [[nodiscard]] _LIBCPP_INLINE_VISIBILITY constexpr bool empty() const noexcept { return _Extent == 0; }
 
----------------
Since the block was manually aligned it would be nice to keep it that way.


================
Comment at: libcxx/test/std/containers/views/span.obs/empty.nodiscard.verify.cpp:18
+//
+
+
----------------
Minor nit can you remove the `//` and the extra blank line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111516/new/

https://reviews.llvm.org/D111516