[libcxx-commits] [PATCH] D111458: [RFC][libc++] Use issue labels.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 11 08:57:05 PDT 2021


Mordante added inline comments.


================
Comment at: libcxx/docs/Helpers/Styles.rst:33
 
 .. |Not Started| replace:: :notstarted:`Not Started`
 .. |Nothing To Do| replace:: :nothingtodo:`Nothing To Do`
----------------
jloser wrote:
> Do we plan on consistently using this? I see we used it in `FormatIssues.csv` and `SpaceshipProjects.csv`. Right now in the papers docs, we don't write anything (that, empty implies "Not Started"). Should we fill the empty ones in with "Not Started" or leave it as empty? I don't feel strongly, but I like consistency one way or another. I'm OK if you also see that as out-of-scope for this particular labeling PR.
I think it would be nice to discuss that, but I think Discord would be a better place. When we want that change I don't mind to make a PR, but should be a separate PR.


================
Comment at: libcxx/docs/Helpers/Styles.rst:48
+.. |ranges| replace:: :ranges:`ranges`
+.. |spaceship| replace:: :spaceship:`spaceship`
+
----------------
mumbleskates wrote:
> These replacements can and should hyperlink to the relevant papers page!
That could be done is some cases. Chrono is tricky since at the moment all chrono issues are chrono formatting issues. But in the future chono can have its own page; I think there's enough left of C++20 chrono to warrant its own page.

Do we want page links and if so should we make a separate group for `|format chrono|`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111458/new/

https://reviews.llvm.org/D111458



More information about the libcxx-commits mailing list