[libcxx-commits] [PATCH] D111516: [libc++][docs] Mark LWG3274 as complete

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/docs/Status/Cxx20Issues.csv:186
 "`3103 <https://wg21.link/LWG3103>`__","Errors in taking subview of ``span``\  should be ill-formed where possible","Belfast","",""
-"`3274 <https://wg21.link/LWG3274>`__","Missing feature test macro for ``<span>``\ ","Belfast","",""
+"`3274 <https://wg21.link/LWG3274>`__","Missing feature test macro for ``<span>``\ ","Belfast","|Complete|","11.0"
 "`3276 <https://wg21.link/LWG3276>`__","Class ``split_view::outer_iterator::value_type``\  should inherit from ``view_interface``\ ","Belfast","",""
----------------
The feature test macro has indeed been there since forever; but before we mark this "Complete", let's do a pass over the paper that added it
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1024r3.pdf
and see what else might be missing.
- `span::empty()` should be `[[nodiscard]]`
- `tuple_size` should be specialized for spans of non-dynamic extent... nope, this part was removed again in https://cplusplus.github.io/LWG/issue3212 (which is associated with https://wg21.link/P2116 which is already listed as "Complete", so, no action needed on this one)

I think adding `[[nodiscard]]` to `empty()` — and writing a test for that — is all that's needed, then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111516/new/

https://reviews.llvm.org/D111516