[libcxx-commits] [PATCH] D111458: [RFC][libc++] Use issue labels.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Oct 10 10:16:13 PDT 2021


Mordante added inline comments.


================
Comment at: libcxx/docs/Helpers/Styles.rst:20-23
+        .chrono { background-color: #00FFFF; }
+        .format { background-color: #1E90FF; }
+        .ranges { background-color: #32CD32; }
+        .spaceship { background-color: #CD5C5C; }
----------------
Mordante wrote:
> mumbleskates wrote:
> > Quuxplusone wrote:
> > > Looking at the screenshot, I suggest lighter shades; perhaps `#E6E6FA`, `#FAFAD2`, `#7FFFD4`, `#B0E0E6`, `#FAEBD7`, `#F5F5DC`.
> > > https://www.w3schools.com/colors/colors_groups.asp
> > > `#CD5C5C` and `#1E90FF` particularly are too dark to comfortably read black-text-on-X-background.
> > another possibility for background colors is to choose a strong primary with a middling opacity, which avoids becoming unreadable in high-contrast or inverted userstyles.
> I looked at your suggestions. I think the first two are too light, I picked a darker shade from the suggested group.
I noticed this comment after I updated the colors. Do you have suggestions for alternative colors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111458/new/

https://reviews.llvm.org/D111458



More information about the libcxx-commits mailing list