[libcxx-commits] [PATCH] D111458: [RFC][libc++] Use issue labels.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Oct 10 09:41:25 PDT 2021


Quuxplusone added inline comments.


================
Comment at: libcxx/docs/Helpers/Styles.rst:20-23
+        .chrono { background-color: #00FFFF; }
+        .format { background-color: #1E90FF; }
+        .ranges { background-color: #32CD32; }
+        .spaceship { background-color: #CD5C5C; }
----------------
Looking at the screenshot, I suggest lighter shades; perhaps `#E6E6FA`, `#FAFAD2`, `#7FFFD4`, `#B0E0E6`, `#FAEBD7`, `#F5F5DC`.
https://www.w3schools.com/colors/colors_groups.asp
`#CD5C5C` and `#1E90FF` particularly are too dark to comfortably read black-text-on-X-background.


================
Comment at: libcxx/docs/Status/Cxx20Issues.csv:9
+"1234","Format","???","|Complete|",12.0,"|format|"
+"1234","Format + Chrono","???","|Complete|",12.0,"|format|, |chrono|"
+"1234","Ranges","???","|Complete|",12.0,"|ranges|"
----------------
I suggest no comma between tags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111458/new/

https://reviews.llvm.org/D111458



More information about the libcxx-commits mailing list