[libcxx-commits] [PATCH] D111265: [libc++] Add an option to disable wide character support in libc++

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/CMakeLists.txt:123
    embedded)." ON)
+option(LIBCXX_ENABLE_WIDE_CHARACTERS
+  "Whether to include support for wide characters in the library. Disabling
----------------
ldionne wrote:
> Mordante wrote:
> > Can you add this option to `docs/BuildingLibcxx.rst`?
> > 
> > Is this feature worth mentioning in the release notes?
> Did both, good suggestions!
> 
> As a self note, I don't really like the duplication of information between the CMake file and the Sphinx documentation for build options. They are often out-of-sync and not everything is everywhere. But I just wanted to raise awareness about the situation -- this isn't the right place to fix it.
I agree I think we mentioned this duplication issue before.


================
Comment at: libcxx/include/__mbstate_t.h:31
+#else
+#   include <sys/_types/_mbstate_t.h> // works on Darwin
+#endif
----------------
This fixes this compilation error on my system. 


================
Comment at: libcxx/include/locale:218
 #else
 #include <__bsd_locale_fallbacks.h>
 #endif
----------------
After fixing `mbstate_t` this header give me issues.
Commenting out a set of functions fixed my build issues.
For your convenience I created D111492 with my local modifications which is building here
https://buildkite.com/llvm-project/libcxx-ci/builds/5848


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111265/new/

https://reviews.llvm.org/D111265