[libcxx-commits] [PATCH] D111197: [libc++] Verify span and string_view are trivially copyable

[Joe Loser via Phabricator via libcxx-commits]

jloser updated this revision to Diff 378353.
jloser added a comment.

Rebase and mark P2251 <https://reviews.llvm.org/P2251> complete in Cxx2bPapers.csv

If BuildKite is still happy, I'll land this as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111197/new/

https://reviews.llvm.org/D111197

Files:
  libcxx/docs/Status/Cxx2bPapers.csv
  libcxx/test/std/containers/views/trivially_copyable.compile.pass.cpp
  libcxx/test/std/strings/string.view/trivially_copyable.compile.pass.cpp


Index: libcxx/test/std/strings/string.view/trivially_copyable.compile.pass.cpp
===================================================================
--- /dev/null
+++ libcxx/test/std/strings/string.view/trivially_copyable.compile.pass.cpp
@@ -0,0 +1,24 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// P2251 was voted into C++23, but libc++ guarantees triviality in all Standard modes,
+// so we enable the test in all Standard modes for libc++.
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14 || c++17 || c++20)
+
+// <string_view>
+
+#include <string_view>
+#include <type_traits>
+
+static_assert(std::is_trivially_copyable<std::basic_string_view<char> >::value, "");
+static_assert(std::is_trivially_copyable<std::basic_string_view<wchar_t> >::value, "");
+#ifndef _LIBCPP_HAS_NO_CHAR8_T
+static_assert(std::is_trivially_copyable<std::basic_string_view<char8_t> >::value, "");
+#endif
+static_assert(std::is_trivially_copyable<std::basic_string_view<char16_t> >::value, "");
+static_assert(std::is_trivially_copyable<std::basic_string_view<char32_t> >::value, "");
Index: libcxx/test/std/containers/views/trivially_copyable.compile.pass.cpp
===================================================================
--- /dev/null
+++ libcxx/test/std/containers/views/trivially_copyable.compile.pass.cpp
@@ -0,0 +1,19 @@
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
+// P2251 is supported by libc++ even in C++20 mode.
+// UNSUPPORTED: !stdlib=libc++ && c++20
+
+// <span>
+
+#include <span>
+#include <type_traits>
+
+static_assert(std::is_trivially_copyable_v<std::span<int>>);
+static_assert(std::is_trivially_copyable_v<std::span<int, 3>>);
Index: libcxx/docs/Status/Cxx2bPapers.csv
===================================================================
--- libcxx/docs/Status/Cxx2bPapers.csv
+++ libcxx/docs/Status/Cxx2bPapers.csv
@@ -31,7 +31,7 @@
 "`P1272 <https://wg21.link/P1272>`__","LWG","Byteswapping for fun&&nuf","October 2021","",""
 "`P1675 <https://wg21.link/P1675>`__","LWG","``rethrow_exception`` must be allowed to copy","October 2021","",""
 "`P2077 <https://wg21.link/P2077>`__","LWG","Heterogeneous erasure overloads for associative containers","October 2021","",""
-"`P2251 <https://wg21.link/P2251>`__","LWG","Require ``span`` & ``basic_string_view`` to be Trivially Copyable","October 2021","",""
+"`P2251 <https://wg21.link/P2251>`__","LWG","Require ``span`` & ``basic_string_view`` to be Trivially Copyable","October 2021","|Complete|","14.0"
 "`P2301 <https://wg21.link/P2301>`__","LWG","Add a ``pmr`` alias for ``std::stacktrace``","October 2021","",""
 "`P2321 <https://wg21.link/P2321>`__","LWG","``zip``","October 2021","",""
 "`P2340 <https://wg21.link/P2340>`__","LWG","Clarifying the status of the 'C headers'","October 2021","",""


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111197.378353.patch
Type: text/x-patch
Size: 3404 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211008/096ef408/attachment.bin>