[libcxx-commits] [PATCH] D111265: [libc++] Add an option to disable wide character support in libc++

[Louis Dionne via Phabricator via libcxx-commits]

ldionne updated this revision to Diff 378349.
ldionne marked 5 inline comments as done.
ldionne added a comment.

Address review comments. This should still fail on Linux, I'll address that next week.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111265/new/

https://reviews.llvm.org/D111265

Files:
  libcxx/CMakeLists.txt
  libcxx/cmake/caches/Generic-no-wide-characters.cmake
  libcxx/docs/BuildingLibcxx.rst
  libcxx/docs/ReleaseNotes.rst
  libcxx/include/CMakeLists.txt
  libcxx/include/__algorithm/sort.h
  libcxx/include/__config
  libcxx/include/__config_site.in
  libcxx/include/__format/format_context.h
  libcxx/include/__format/format_parse_context.h
  libcxx/include/__format/formatter_bool.h
  libcxx/include/__format/formatter_char.h
  libcxx/include/__functional/hash.h
  libcxx/include/__locale
  libcxx/include/__mbstate_t.h
  libcxx/include/__string
  libcxx/include/__utility/cmp.h
  libcxx/include/atomic
  libcxx/include/codecvt
  libcxx/include/cstddef
  libcxx/include/experimental/regex
  libcxx/include/experimental/string
  libcxx/include/filesystem
  libcxx/include/format
  libcxx/include/iosfwd
  libcxx/include/iostream
  libcxx/include/istream
  libcxx/include/locale
  libcxx/include/module.modulemap
  libcxx/include/ostream
  libcxx/include/regex
  libcxx/include/string
  libcxx/include/string_view
  libcxx/include/wchar.h
  libcxx/include/wctype.h
  libcxx/src/algorithm.cpp
  libcxx/src/ios.instantiations.cpp
  libcxx/src/iostream.cpp
  libcxx/src/locale.cpp
  libcxx/src/string.cpp
  libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
  libcxx/test/libcxx/depr/depr.c.headers/extern_c.pass.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/mbstate_t.h.module.verify.cpp
  libcxx/test/libcxx/double_include.sh.cpp
  libcxx/test/libcxx/include_as_c.sh.cpp
  libcxx/test/libcxx/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp
  libcxx/test/libcxx/input.output/filesystems/class.path/path.req/is_pathable.pass.cpp
  libcxx/test/libcxx/input.output/iostream.format/input.streams/traits_mismatch.fail.cpp
  libcxx/test/libcxx/input.output/iostream.format/output.streams/traits_mismatch.fail.cpp
  libcxx/test/libcxx/input.output/string.streams/traits_mismatch.fail.cpp
  libcxx/test/libcxx/iterators/contiguous_iterators.pass.cpp
  libcxx/test/libcxx/iterators/failed.pass.cpp
  libcxx/test/libcxx/iterators/iterator.requirements/iterator.concepts/integer_like.compile.pass.cpp
  libcxx/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp
  libcxx/test/libcxx/min_max_macros.compile.pass.cpp
  libcxx/test/libcxx/no_assert_include.compile.pass.cpp
  libcxx/test/libcxx/strings/c.strings/version_cwchar.pass.cpp
  libcxx/test/libcxx/strings/c.strings/version_cwctype.pass.cpp
  libcxx/test/libcxx/type_traits/convert_to_integral.pass.cpp
  libcxx/test/libcxx/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
  libcxx/test/libcxx/utilities/format/format.arguments/format.args/get.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_bool.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_char.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_integer.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_non_unicode.pass.cpp
  libcxx/test/libcxx/utilities/format/format.string/format.string.std/std_format_spec_string_unicode.pass.cpp
  libcxx/test/std/atomics/atomics.types.generic/integral.pass.cpp
  libcxx/test/std/atomics/atomics.types.generic/integral_typedefs.pass.cpp
  libcxx/test/std/atomics/types.pass.cpp
  libcxx/test/std/concepts/concepts.lang/concept.default.init/default_initializable.compile.pass.cpp
  libcxx/test/std/depr/depr.c.headers/stdint_h.pass.cpp
  libcxx/test/std/depr/depr.c.headers/wchar_h.pass.cpp
  libcxx/test/std/depr/depr.c.headers/wctype_h.pass.cpp
  libcxx/test/std/experimental/iterator/ostream.joiner/ostream.joiner.cons/ostream_joiner.cons.pass.cpp
  libcxx/test/std/experimental/iterator/ostream.joiner/ostream.joiner.ops/ostream_joiner.op.assign.pass.cpp
  libcxx/test/std/experimental/iterator/ostream.joiner/ostream.joiner.ops/ostream_joiner.op.postincrement.pass.cpp
  libcxx/test/std/experimental/iterator/ostream.joiner/ostream.joiner.ops/ostream_joiner.op.pretincrement.pass.cpp
  libcxx/test/std/experimental/iterator/ostream.joiner/ostream.joiner.ops/ostream_joiner.op.star.pass.cpp
  libcxx/test/std/experimental/memory/memory.resource.aliases/header_regex_synop.pass.cpp
  libcxx/test/std/experimental/memory/memory.resource.aliases/header_string_synop.pass.cpp
  libcxx/test/std/input.output/file.streams/c.files/cinttypes.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.cons/default.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.cons/move.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.members/open_pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.virtuals/overflow.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.virtuals/seekoff.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/filebuf.virtuals/underflow.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/default.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/move.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/string.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/close.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/open_string.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/fstream.members/rdbuf.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/default.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/move.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/string.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/close.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/open_pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/open_string.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/rdbuf.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/default.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/move.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.cons/string.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/close.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_path.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_pointer.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/open_string.pass.cpp
  libcxx/test/std/input.output/file.streams/fstreams/ofstream.members/rdbuf.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/source.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.concat.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.construct/source.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/generic_string_alloc.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.generic.obs/named_overloads.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/named_overloads.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.nonmember/path.io.pass.cpp
  libcxx/test/std/input.output/iostream.format/ext.manip/get_money.pass.cpp
  libcxx/test/std/input.output/iostream.format/ext.manip/get_time.pass.cpp
  libcxx/test/std/input.output/iostream.format/ext.manip/put_money.pass.cpp
  libcxx/test/std/input.output/iostream.format/ext.manip/put_time.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/iostreamclass/iostream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/iostreamclass/iostream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/iostreamclass/iostream.cons/move.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/iostreamclass/iostream.cons/streambuf.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/bool.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/double.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/float.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/int.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long_double.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/long_long.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/short.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_int.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_long.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_long_long.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream.formatted.arithmetic/unsigned_short.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extractors/chart.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extractors/streambuf.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extractors/wchar_t_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.manip/ws.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.rvalue/rvalue.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_chart.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_pointer_size.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_pointer_size_chart.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_streambuf.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/get_streambuf_chart.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/getline_pointer_size.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/getline_pointer_size_chart.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/ignore.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/peek.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/putback.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/read.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/readsome.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/seekg.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/seekg_off.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/sync.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/tellg.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream.unformatted/unget.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream/istream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream/istream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream/istream.cons/move.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream/istream.cons/streambuf.pass.cpp
  libcxx/test/std/input.output/iostream.format/input.streams/istream/istream_sentry/ctor.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.assign/move_assign.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.cons/move.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.cons/streambuf.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/CharT.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/CharT_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_to_wide.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_to_wide_pointer.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/endl.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/ends.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/flush.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.rvalue/rvalue.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.unformatted/put.pass.cpp
  libcxx/test/std/input.output/iostream.format/output.streams/ostream.unformatted/write.pass.cpp
  libcxx/test/std/input.output/iostream.format/quoted.manip/quoted.pass.cpp
  libcxx/test/std/input.output/iostream.format/quoted.manip/quoted_char.verify.cpp
  libcxx/test/std/input.output/iostream.format/std.manip/resetiosflags.pass.cpp
  libcxx/test/std/input.output/iostream.format/std.manip/setbase.pass.cpp
  libcxx/test/std/input.output/iostream.format/std.manip/setfill.pass.cpp
  libcxx/test/std/input.output/iostream.format/std.manip/setiosflags.pass.cpp
  libcxx/test/std/input.output/iostream.format/std.manip/setprecision.pass.cpp
  libcxx/test/std/input.output/iostream.format/std.manip/setw.pass.cpp
  libcxx/test/std/input.output/iostream.forward/iosfwd.pass.cpp
  libcxx/test/std/input.output/iostream.objects/init.pass.cpp
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcerr.sh.cpp
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcin.sh.cpp
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wclog.sh.cpp
  libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcout.sh.cpp
  libcxx/test/std/input.output/iostreams.base/ios/basic.ios.members/narrow.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.cons/copy.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.cons/default.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.assign/assign.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.assign/swap.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.get.area/gbump.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.get.area/setg.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/setp.pass.cpp
  libcxx/test/std/input.output/stream.buffers/streambuf/types.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.assign/move.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/default.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/move.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.cons/string.pass.cpp
  libcxx/test/std/input.output/string.streams/istringstream/istringstream.members/str.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.assign/move.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/default.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/move.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.cons/string.pass.cpp
  libcxx/test/std/input.output/string.streams/ostringstream/ostringstream.members/str.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.assign/member_swap.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.assign/move.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.assign/nonmember_swap.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.cons/move.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.cons/string.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.members/str.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/overflow.pass.cpp
  libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.virtuals/pbackfail.pass.cpp
  (358 more files...)