[libcxx-commits] [PATCH] D111265: [libc++] Add an option to disable wide character support in libc++

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I agree we should try to land this as quickly as possible, this patch seems a huge effort!
I mainly looked at the buildsystem related, format related and locale files. I mostly ignored the tests; I expect Buildkite to help there.

I didn't see any huge issues.



================
Comment at: libcxx/CMakeLists.txt:123
    embedded)." ON)
+option(LIBCXX_ENABLE_WIDE_CHARACTERS
+  "Whether to include support for wide characters in the library. Disabling
----------------
Can you add this option to `docs/BuildingLibcxx.rst`?

Is this feature worth mentioning in the release notes?


================
Comment at: libcxx/include/__format/formatter_bool.h:94
 };
+#endif
 
----------------
Can you modify `formatter_char.h` in this directory and disable `formatter<char, wchar_t>` and `formatter<wchar_t, wchar_t>`?


================
Comment at: libcxx/include/regex:1073
     template <class _ForwardIterator>
-        string_type
-        __transform_primary(_ForwardIterator __f, _ForwardIterator __l, char) const;
----------------
I'm not fond of formatting changes in this patch. I would strongly recommend to just commit the format changes now so this patch looks cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111265/new/

https://reviews.llvm.org/D111265