[libcxx-commits] [PATCH] D111323: [SystemZ][z/OS] ASCII/EBCDIC support for libc++

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

This is above my pay grade, but FWIW, this looks //to me// like a huge unmaintainable complication. It feels bad to say "//you// must take on the huge burden of maintaining this out-of-tree," but IMHO it would be worse for libc++ to say "//libc++// should take on the burden of maintaining this in-tree."
If @ldionne feels the same, then perhaps a compromise approach would be to propose merely granularizing the `src/` files enough to segregate "code affected by this patch" from "code that isn't." Right now the PR is a maze of `#ifdef`s; I assume it would be easier for you to maintain an out-of-tree patch if it was just "swap out these few specific files."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111323/new/

https://reviews.llvm.org/D111323