[libcxx-commits] [PATCH] D111197: [libc++] Verify span and string_view are trivially copyable

[Joe Loser via Phabricator via libcxx-commits]

jloser updated this revision to Diff 377618.
jloser added a comment.

Address review feedback


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111197/new/

https://reviews.llvm.org/D111197

Files:
  libcxx/test/std/containers/views/trivially_copyable.compile.pass.cpp
  libcxx/test/std/strings/string.view/trivially_copyable.compile.pass.cpp


Index: libcxx/test/std/strings/string.view/trivially_copyable.compile.pass.cpp
===================================================================
--- /dev/null
+++ libcxx/test/std/strings/string.view/trivially_copyable.compile.pass.cpp
@@ -0,0 +1,22 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// P2251 was voted into C++23, but libc++ guarantees triviality in all Standard modes,
+// so we enable the test in all Standard modes for libc++.
+// UNSUPPORTED: !stdlib=libc++ && (c++03 || c++11 || c++14 || c++17 || c++20)
+
+// <string_view>
+
+#include <string_view>
+#include <type_traits>
+
+static_assert(std::is_trivially_copyable<std::basic_string_view<char> >::value, "");
+static_assert(std::is_trivially_copyable<std::basic_string_view<wchar_t> >::value, "");
+static_assert(std::is_trivially_copyable<std::basic_string_view<char8_t> >::value, "");
+static_assert(std::is_trivially_copyable<std::basic_string_view<char16_t> >::value, "");
+static_assert(std::is_trivially_copyable<std::basic_string_view<char32_t> >::value, "");
Index: libcxx/test/std/containers/views/trivially_copyable.compile.pass.cpp
===================================================================
--- /dev/null
+++ libcxx/test/std/containers/views/trivially_copyable.compile.pass.cpp
@@ -0,0 +1,19 @@
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// UNSUPPORTED: c++03, c++11, c++14, c++17
+
+// P2251 is supported by libc++ even in C++20 mode.
+// UNSUPPORTED: !stdlib=libc++ && c++20
+
+// <span>
+
+#include <span>
+#include <type_traits>
+
+static_assert(std::is_trivially_copyable_v<std::span<int>>);
+static_assert(std::is_trivially_copyable_v<std::span<int, 3>>);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111197.377618.patch
Type: text/x-patch
Size: 2244 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211006/463fdb3e/attachment.bin>