[libcxx-commits] [PATCH] D111231: [libc++] [test] Change a lot of free begin/end pairs to members. NFCI.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

Maybe mention in the commit message why changing from friends to member functions.

I assume you plan a followup to resolve the new todos?

LGTM, one small suggestion.



================
Comment at: libcxx/test/std/ranges/range.adaptors/range.transform/types.h:21
   int *ptr_;
   constexpr ContiguousView(int* ptr = globalBuff, int start = 0) : start_(start), ptr_(ptr) {}
   constexpr ContiguousView(ContiguousView&&) = default;
----------------
While you're at it, maybe adding `explicit` in this file too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111231/new/

https://reviews.llvm.org/D111231