[libcxx-commits] [PATCH] D111173: [libc++] Refactor how basic_string and vector hoist exception-throwing functions

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/string:677
     basic_string
-    : private __basic_string_common<true>
+    : private __basic_string_common<true> // This base class is historical, but it needs to remain for ABI compatibility
 {
----------------
Do we want to remove this is ABI v2?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111173/new/

https://reviews.llvm.org/D111173