[libcxx-commits] [PATCH] D110852: [libc++] Use addressof in assignment operator.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/containers/sequences/forwardlist/forwardlist.cons/assign_copy.compile.pass.cpp:9
+
+// UNSUPPORTED: libcxx-no-debug-mode
+
----------------
ldionne wrote:
> Why does this test require the debug mode?
It doesn't I noticed it before uploading the changes yesterday, but seems I forgot to hit the save button.


================
Comment at: libcxx/test/std/containers/sequences/list/list.cons/assign_copy.compile.pass.cpp:9
+
+// XFAIL: LIBCXX-DEBUG-FIXME
+
----------------
Quuxplusone wrote:
> ldionne wrote:
> > Can you add a comment explaining why that fails? Applies elsewhere too.
> Good catches! I didn't notice these new XFAILs; I also don't see any reason they should be needed. I assume the problem has to do with `__wrap_iter` not being sufficiently ADL-proof? But then we should fix that too.
They fail since the debug iterators also use `operator&`. As stated in the original commit message; there will be follow-up commits. I prefer to keep reviews small. I'll add comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110852/new/

https://reviews.llvm.org/D110852