[libcxx-commits] [PATCH] D111138: [libcxx][pretty printers] Correct locale for u16/u32 string tests

David Spickett via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 6 08:08:20 PDT 2021


DavidSpickett updated this revision to Diff 377552.
DavidSpickett retitled this revision from " [libcxx][pretty printers] Correct locale for u16/u32 string tests" to "[libcxx][pretty printers] Correct locale for u16/u32 string tests".
DavidSpickett added a comment.

Moving the dockerfile change into a separate diff that installs all
the needed locales for the test suite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111138/new/

https://reviews.llvm.org/D111138

Files:
  libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp


Index: libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
===================================================================
--- libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
+++ libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
@@ -7,12 +7,13 @@
 //===----------------------------------------------------------------------===//
 
 // REQUIRES: host-has-gdb-with-python
+// REQUIRES: locale.en_US.UTF-8
 // UNSUPPORTED: libcpp-has-no-localization
 // UNSUPPORTED: c++03
 
 // RUN: %{cxx} %{flags} %s -o %t.exe %{compile_flags} -g %{link_flags}
 // Ensure locale-independence for unicode tests.
-// RUN: %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe
+// RUN: env LANG=en_US.UTF-8 %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe
 
 #include <bitset>
 #include <deque>
@@ -658,6 +659,7 @@
   string_test();
   a_namespace::string_view_test();
 
+  u16string_test();
   u32string_test();
   tuple_test();
   unique_ptr_test();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111138.377552.patch
Type: text/x-patch
Size: 1229 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211006/7eb13067/attachment-0001.bin>


More information about the libcxx-commits mailing list