[libcxx-commits] [PATCH] D110503: [libc++] Implement P1394r4 for span: range constructor

Wed Oct 6 07:40:10 PDT 2021

jloser marked 4 inline comments as done.
jloser added inline comments.

================
Comment at: libcxx/test/std/containers/views/span.cons/assign.pass.cpp:12
+// AppleClang 12.0.0 doesn't fully support ranges/concepts
+// XFAIL: apple-clang-12.0.0

----------------
ldionne wrote:
> It just occurred to me that if you wanted, you could also replace all those `XFAIL: apple-clang-12.0.0` by `XFAIL: libcpp-no-concepts`. IDK why I didn't think of that sooner. Feel free to do it or not, those are both temporary things anyway.
Eh, I'll leave it as is for now. I'm hoping it won't live very long as we talked about since we're dropping support for `AppleClang 12.0.0` shortly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110503/new/

https://reviews.llvm.org/D110503