[libcxx-commits] [PATCH] D110503: [libc++] Implement P1394r4 for span: range constructor

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 4 07:51:11 PDT 2021


jloser updated this revision to Diff 376897.
jloser added a comment.

Address some of Arthur's feedback.

- test_from_range should return void - cleans up some asserts in callers
- Adjust tests a bit in range.pass.cpp to avoid dependency on deque
- Reoganize some tests for clarity in range.pass.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110503/new/

https://reviews.llvm.org/D110503

Files:
  libcxx/docs/Status/Cxx20Papers.csv
  libcxx/include/span
  libcxx/test/std/containers/views/span.cons/container.fail.cpp
  libcxx/test/std/containers/views/span.cons/container.pass.cpp
  libcxx/test/std/containers/views/span.cons/deduct.pass.cpp
  libcxx/test/std/containers/views/span.cons/iterator_len.pass.cpp
  libcxx/test/std/containers/views/span.cons/iterator_len.verify.cpp
  libcxx/test/std/containers/views/span.cons/iterator_sentinel.pass.cpp
  libcxx/test/std/containers/views/span.cons/iterator_sentinel.verify.cpp
  libcxx/test/std/containers/views/span.cons/ptr_len.fail.cpp
  libcxx/test/std/containers/views/span.cons/ptr_len.pass.cpp
  libcxx/test/std/containers/views/span.cons/ptr_ptr.fail.cpp
  libcxx/test/std/containers/views/span.cons/ptr_ptr.pass.cpp
  libcxx/test/std/containers/views/span.cons/range.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110503.376897.patch
Type: text/x-patch
Size: 55512 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211004/fff112db/attachment-0001.bin>


More information about the libcxx-commits mailing list