[libcxx-commits] [PATCH] D101458: [libc++][libc++abi] Install libc++abi headers from libc++abi, not libc++

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: llvm/utils/gn/secondary/libcxx/include/BUILD.gn:271-281
-    if (target_os != "mac" && target_os != "win") {
-      # libcxx/cmake/Modules/HandleLibCXXABI.cmake sets
-      # LIBCXX_CXX_ABI_HEADER_TARGET if the libcxx abi library either of
-      # "libstdc++", "libsupc++", "libcxxabi", "libcxxrt", but not if it's "none",
-      # "default", or "vcruntime". So on Windows, these don't get copied due to
-      # LIBCXX_CXX_ABI_HEADER_TARGET not being set.
-      # On macOS, libcxx/CMakeLists.txt sets LIBCXX_CXX_ABI_SYSTEM to 1, which
----------------
ldionne wrote:
> Trying to save you a headache @thakis, but I'd like you to double-check this is OK.
@thakis I suspect you'll have more fixing up to do since you need to install the libc++abi headers from the libc++abi build. I'll just drop this GN change to avoid muddying the waters, but I'm still giving you this heads up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101458/new/

https://reviews.llvm.org/D101458