[libcxx-commits] [PATCH] D110872: [runtimes][ci] Run the tests for libunwind in the CI

Tue Oct 5 15:08:33 PDT 2021

ldionne added subscribers: MaskRay, vitalybuka.
ldionne added a comment.

In D110872#3043948 <https://reviews.llvm.org/D110872#3043948>, @jloser wrote:

> In D110872#3043923 <https://reviews.llvm.org/D110872#3043923>, @ldionne wrote:
>
>> Add a bunch of XFAILs. This is really bad, we have like 8 tests and more than half
>> of them are failing even in some common configurations. We'll need some serious
>> investigation.
>
> Yikes.

I am pretty sure that all the tests used to pass on macOS a couple years ago, but apparently a lot of changes have landed without proper CI and testing, so now they're red.

Pinging some people who have touched libunwind lately: @vitalybuka @MaskRay @danielkiss. I'm not sure who's closest to being a libunwind code owner, but it would be awesome if we could get a grip over the project. I'd do it, but libc++ and libc++abi are already borderline too much. I'll add this CI to avoid introducing new regressions, at least that's one step forward.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110872/new/

https://reviews.llvm.org/D110872