[libcxx-commits] [PATCH] D110994: [libc++] Make test_allocator constexpr-friendly for constexpr string/vector

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

A few small nits, but I want to have a closer look when I have more time, unless Louis beats me to it.
Can you make sure you mark all comments done as done?



================
Comment at: libcxx/test/support/test_allocator.h:89
+
+  TEST_CONSTEXPR_CXX14 explicit test_allocator(int data, test_allocator_statistics* stats) TEST_NOEXCEPT
+      : data_(data),
----------------
Nit: Only a part of the constructors is `explicit`; please make all appropriate ones `explicit`.


================
Comment at: libcxx/test/support/test_allocator.h:96
+
+  TEST_CONSTEXPR explicit test_allocator(int data, int id) : data_(data), id_(id) {}
+
----------------
Nit: Please make `TEST_NOEXCEPT`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110994/new/

https://reviews.llvm.org/D110994