[libcxx-commits] [PATCH] D111138: [libcxx][pretty printers] Skip u16/u32 string printer tests

Sterling Augustine via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 5 10:08:06 PDT 2021


saugustine added a comment.

Changing my current locale to POSIX from en_US.utf-8 reproduces this problem. I just use the default ubuntu locale normally. I don't have ANSI_X3.4-1968 installed, but I suspect the issue is the same. I expect the tests will pass if you switch LANG=en_US.utf-8--but would be good to check.

Not entirely sure the best thing to do here that will be robust to unexpected locales. We can either update the tests to set the locale, or not run if the locale isn't what we expect. Or try a couple of different matching strings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111138/new/

https://reviews.llvm.org/D111138



More information about the libcxx-commits mailing list