[libcxx-commits] [PATCH] D67086: Implement syncstream (p0053)

[Joe Sylve via Phabricator via libcxx-commits]

joe.sylve added inline comments.


================
Comment at: libcxx/include/syncstream:288
+inline _LIBCPP_INLINE_VISIBILITY
+basic_syncbuf<_CharT, _Traits, _Allocator>::basic_syncbuf(basic_syncbuf&& __other)
+    : __wrapped(_VSTD::move(__other.get_wrapped())),
----------------
This move constructor will lose the existing buffered contents.  Is this intended?  I'd expect that the __str buffer would also be moved and the base class's pointers adjusted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67086/new/

https://reviews.llvm.org/D67086