[libcxx-commits] [PATCH] D111148: [libc++][test] Use = delete over DELETE_FUNCTION. NFC.

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

In D111148#3042824 <https://reviews.llvm.org/D111148#3042824>, @Quuxplusone wrote:

> LGTM, but, have you tried just inlining `= delete;` in all these places? I believe Clang supports it in C++03 mode, and we don't care about other compilers in C++03 mode.

Just tried inlining `= delete;` everywhere. We'll see if BuildKite is happy! It seems you're right that Clang supports it in C++03 mode. A warning is issued, but the `libc++` tests run with `-Wno-c++11-extensions`, so we should be OK. Small example at https://godbolt.org/z/KvYKMqWfz


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111148/new/

https://reviews.llvm.org/D111148