[libcxx-commits] [PATCH] D111138: [libcxx][pretty printers] Skip u16/u32 string printer tests

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett created this revision.
Herald added subscribers: pengfei, kristof.beyls.
DavidSpickett requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

These tests fail on all of the combinations of gdb and python
that I've tried. On Ubuntu Bionic and Focal, on AArch64/Arm and x86.

Known to not work are:
gdb 9.2 using python3.8
gdb 10.1 using python 2.7.18

Py2 vs Py3 fails with different output but I've been unable
to understand where a fix might go.

There are probably some bots that do pass this test but I've
been unable to find any and certainly no bot in the current
precommit can even run it at all.

When we move to Focal this test will run and it will fail
this subset of the test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111138

Files:
  libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp


Index: libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
===================================================================
--- libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
+++ libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
@@ -658,7 +658,9 @@
   string_test();
   a_namespace::string_view_test();
 
-  u32string_test();
+  // Skipped because they fail on most gdb/python combinations
+  //u16string_test();
+  //u32string_test();
   tuple_test();
   unique_ptr_test();
   shared_ptr_test();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111138.377161.patch
Type: text/x-patch
Size: 513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211005/d6046e89/attachment.bin>