[libcxx-commits] [PATCH] D110718: [libc++] Implement P1391 for string_view

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/docs/Status/Cxx20Papers.csv:174
 "`P1831 <https://wg21.link/P1831>`__","LWG","Deprecating volatile: library","Prague","* *",""
 "`P1868 <https://wg21.link/P1868>`__","LWG","width: clarifying units of width and precision in std::format","Prague","|In Progress|",""
 "`P1908 <https://wg21.link/P1908>`__","CWG","Reserving Attribute Namespaces for Future Use","Prague","* *",""
----------------
Mordante wrote:
> jloser wrote:
> > Mordante wrote:
> > > This looks wrong. Is it a rebase error?
> > Mind elaborating? This PR only touches one line in `Cxx20Papers.csv` which is to mark P1391 as complete.
> > 
> > ```
> > diff --git a/libcxx/docs/Status/Cxx20Papers.csv b/libcxx/docs/Status/Cxx20Papers.csv
> > index ee59d657b9f2..c722b9676b4a 100644
> > --- a/libcxx/docs/Status/Cxx20Papers.csv
> > +++ b/libcxx/docs/Status/Cxx20Papers.csv
> > @@ -134,7 +134,7 @@
> >  "`P1754 <https://wg21.link/P1754>`__","LWG","Rename concepts to standard_case for C++20, while we still can","Cologne","|In Progress|",""
> >  "","","","","",""
> >  "`P0883 <https://wg21.link/P0883>`__","LWG","Fixing Atomic Initialization","Belfast","|Complete| [#note-P0883]_","13.0"
> > -"`P1391 <https://wg21.link/P1391>`__","LWG","Range constructor for std::string_view","Belfast","* *",""
> > +"`P1391 <https://wg21.link/P1391>`__","LWG","Range constructor for std::string_view","Belfast","|Complete|","14.0"
> >  "`P1394 <https://wg21.link/P1394>`__","LWG","Range constructor for std::span","Belfast","* *",""
> >  "`P1456 <https://wg21.link/P1456>`__","LWG","Move-only views","Belfast","* *",""
> >  "`P1622 <https://wg21.link/P1622>`__","LWG","Mandating the Standard Library: Clause 32 - Thread support library","Belfast","* *",""
> > ```
> Very odd, have a look at this link https://reviews.llvm.org/D110718?vs=376511&id=376881#toc
> This is the history between Diff 10 and Diff 11, this was the state when I wrote my comment.
> In that view you see a change to P1868. I see the latest diff doesn't have this change.
> I've no clue what happened, but it seems fine now.
Hmm, that's weird. It was a clean rebase, so that's certainly odd.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110718/new/

https://reviews.llvm.org/D110718