[libcxx-commits] [PATCH] D110598: [libc++] P0980R1 (constexpr std::string)

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.ptr.pass.cpp:61
+  assert(!sNot.contains("abcde"));
+  assert(sNot.contains("xyz"));
+  assert(!sNot.contains("zyx"));
----------------
philnik wrote:
> Quuxplusone wrote:
> > In general, I wish you weren't clang-formatting these files as you change them. In //most// cases, Phabricator can deal sensibly with the gratuitous whitespace changes, but in some cases (like this file), the gratuitous whitespace diffs are actively distracting. Remember, //just don't use clang-format// and you won't have problems.
> If you tell me how to disable the linter check before uploading I can do that. But I haven't seen any way around that, since it won't upload unless all lint checks work.
OK forget it. Seems I'm just not capable of reading docs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110598/new/

https://reviews.llvm.org/D110598