[libcxx-commits] [PATCH] D104366: [Demangle][Rust] Parse non-ASCII identifiers

[Tomasz Miąsko via Phabricator via libcxx-commits]

tmiasko added a comment.

In D104366#3037010 <https://reviews.llvm.org/D104366#3037010>, @dblaikie wrote:

> Yeah, I'm fairly comfortable approving a change like this - but now that you mention the libc++abi surface area here: Are other features of Utility.h tested (unit tested?) somewhere? Could you add testing for this new function too?
>
> Also, admittedly I don't fully understand how this LLVM change ended up needing a change to libc++abi - how do these pieces connect/depend on each other?

I added a unit test for OutputStream::insert. It is also indirectly tested by the Rust demangler of course.

libcxxabi carries its own copy of Itanium demangler to implement __cxa_demangle. Those changes are just keeping those two in sync.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104366/new/

https://reviews.llvm.org/D104366