[libcxx-commits] [PATCH] D104366: [Demangle][Rust] Parse non-ASCII identifiers

Fri Oct 1 11:21:02 PDT 2021

dblaikie added a comment.

In D104366#3035856 <https://reviews.llvm.org/D104366#3035856>, @tmiasko wrote:

> Oh, I forgot this didn't land yet and didn't follow up. I wasn't exactly sure how to interpret blocking review by libc++abi. @dblaikie is your review sufficient for landing this?  If not, @ldionne could you take a look at the small part of changes in libcxxabi?

Yeah, I'm fairly comfortable approving a change like this - but now that you mention the libc++abi surface area here: Are other features of Utility.h tested (unit tested?) somewhere? Could you add testing for this new function too?

Also, admittedly I don't fully understand how this LLVM change ended up needing a change to libc++abi - how do these pieces connect/depend on each other?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104366/new/

https://reviews.llvm.org/D104366