[libcxx-commits] [PATCH] D110718: [libc++] Implement P1391

[Corentin Jabot via Phabricator via libcxx-commits]

cor3ntin added inline comments.


================
Comment at: libcxx/include/string_view:88-89
       constexpr basic_string_view(const charT* str, size_type len);
+      template <class It, class End>
+      constexpr basic_string_view(It begin, End end); // C++20
 
----------------
Quuxplusone wrote:
> @cor3ntin: The Tony Table at the beginning of http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1391r4.pdf claims that after this paper, `foo(vec)` will compile... but that's just plain false, correct? IIUC, the actual achievement of p1391 was to make `foo(vec.begin(), vec.end())` compile; and then http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1989r2.pdf is the one that would actually support `foo(vec)`?
> Just checking, because if p1391 isn't wrong, then I'm super confused.
Yes. LWG decided to adopt half the paper in 20, so the change was not reflected in the motivation and the other half was done in 23 in P1989


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110718/new/

https://reviews.llvm.org/D110718