[libcxx-commits] [PATCH] D110887: [libcxx][test] Use python specified by build rather than system default python

[David Spickett via Phabricator via libcxx-commits]

DavidSpickett added a comment.

> So this change doesn't really do anything but make the gdb feature test pass all the time (unless sys.executable happens to literally be python). Since gdb will return status 0 and we won't see "Python not supported".

Since the test itself doesn't check the same thing the feature test does. The idea is that the feature test checks up front what the test needs because if we fail during the test script, the way it's written, gdb will still exit with status 0.

Indeed, the test is showing in the latest buildkite run as being run but not failing and I know for a fact that our existing arm bots' version of gdb is too old to properly run it. Previously it was marked unsupported.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110887/new/

https://reviews.llvm.org/D110887