[libcxx-commits] [PATCH] D114658: [WIP] [libc++] [test] Several test-code refactorings.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, Mordante, libc++, jloser.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

  [libc++] [test] C++03-friendly MAKE_STRING macro.

Used in the new `string_view` test in this PR. (We support `string_view` in C++03. I don't object if we want to just stop doing that.)

  [libc++] [test] Refactor string_view comparison tests for comprehensiveness.

This one probably fails on Win32 right now, as discussed in D113161 <https://reviews.llvm.org/D113161>; but if this were rebased on top of that patch (with its extra template parameters), or if `operator<` et al were reimplemented as hidden friends, then it should pass just fine.

  [libc++] [test] Refactor TEST_IS_CONSTANT_EVALUATED to TEST_IS_RUNTIME.

And `TEST_IS_RUNTIME_OR_CXX20` etc. This turned out to be uglier than I had hoped, and also I ended up not needing to use `TEST_IS_RUNTIME_OR_CXX??` for anything because we haven't implemented constexpr string/vector yet. Not pushing hard for this one, but I figure we might like to pre-discuss it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114658

Files:
  libcxx/test/libcxx/algorithms/robust_against_copying_comparators.pass.cpp
  libcxx/test/std/algorithms/robust_re_difference_type.compile.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opeq.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opeq.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opeq.string_view.string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opeq.string_view.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opge.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opge.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opge.string_view.string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opge.string_view.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opgt.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opgt.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opgt.string_view.string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opgt.string_view.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/ople.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/ople.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/ople.string_view.string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/ople.string_view.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/oplt.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/oplt.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/oplt.string_view.string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/oplt.string_view.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opne.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opne.string_view.pointer.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opne.string_view.string.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/opne.string_view.string_view.pass.cpp
  libcxx/test/support/make_string.h
  libcxx/test/support/test_macros.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114658.390123.patch
Type: text/x-patch
Size: 79686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211126/58688d90/attachment-0001.bin>