[libcxx-commits] [PATCH] D111514: [libc++] [P1614] Implement the second half of [cmp.alg]: compare_{strong, weak, partial}_fallback.

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 22 11:29:37 PST 2021


Quuxplusone updated this revision to Diff 388981.
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.

Rebase after landing D110738 <https://reviews.llvm.org/D110738>. Rename `__e/__f` to `__t/__u`. Remove `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`. Adjust spacing on "you must write it three times"... except, @ldionne, you'll have to tell me what you want to do with the several //multi-line// "three times" bodies in this PR! I've left them alone for now, pending your preferred style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111514/new/

https://reviews.llvm.org/D111514

Files:
  libcxx/docs/Status/Cxx2bIssues.csv
  libcxx/docs/Status/Spaceship.rst
  libcxx/docs/Status/SpaceshipProjects.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__compare/compare_partial_order_fallback.h
  libcxx/include/__compare/compare_strong_order_fallback.h
  libcxx/include/__compare/compare_weak_order_fallback.h
  libcxx/include/compare
  libcxx/include/module.modulemap
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_partial_order_fallback.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_strong_order_fallback.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_weak_order_fallback.module.verify.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/compare_partial_order_fallback.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/compare_strong_order_fallback.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/compare_weak_order_fallback.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111514.388981.patch
Type: text/x-patch
Size: 97221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211122/c7d600a3/attachment-0001.bin>


More information about the libcxx-commits mailing list