[libcxx-commits] [PATCH] D112012: [benchmarks] Move libcxx's fork of google/benchmark and llvm/utils' under third-party

Mircea Trofin via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 16 15:36:16 PST 2021


Oh! Huh, missed that. Probably my ninja check-all didn’t build the
benchmarks. I’ll patch shortly. Sorry for the lapse.

On Tue, Nov 16, 2021 at 14:11 Siva Chandra via Phabricator <
reviews at reviews.llvm.org> wrote:

> sivachandra added a comment.
>
> FYI: The libcxx copy and llvm/utils copy were not identical. So, the libc
> benchmarks are currently broken because of that. I have added an inline
> comment to show the single difference we are seeing. We can fix forward.
>
>
>
> ================
> Comment at: llvm/utils/benchmark/include/benchmark/benchmark.h:1236
> -
> -struct CPUInfo {
> -  struct CacheInfo {
> ----------------
> The definition of this struct is not the same as the one in the libcxx
> copy.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D112012/new/
>
> https://reviews.llvm.org/D112012
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211116/c4db7787/attachment-0001.html>


More information about the libcxx-commits mailing list