[libcxx-commits] [PATCH] D88458: [CMake] Cache the compiler-rt library search results

Tue Nov 16 09:58:55 PST 2021

ldionne added a comment.

In D88458#3130720 <https://reviews.llvm.org/D88458#3130720>, @Abpostelnicu wrote:

> In D88458#3117882 <https://reviews.llvm.org/D88458#3117882>, @phosek wrote:
>
>> So far you're the only one who reached affected by this change which to me suggests that there may not be many projects using the old layout.
>>
>> When LLVM adopted the monorepo we made no guarantees that we would keep the old layout working.
>
> True but this is the first change that breaks it.
>
>> We're also planning larger build changes after LLVM 14 which will likely disrupt you, see https://lists.llvm.org/pipermail/llvm-dev/2021-October/153238.html.
>
> I think we are getting a bit far, there is time till then to do our adjustments.

FWIW I 100% support @phosek here. We are making improvements to our build system that allow us to reduce maintenance costs, increase flexibility of our build system (e.g. for new platforms), reduce the room for mistakes, etc. As often the case with this kind of change, it requires the cooperation from downstream people who use our code.

We have done everything we can to communicate these changes to downstream users and we are giving them a generous grace period, now it is their (your) responsibility to act on that notification. Concretely, please:

1. Make sure you are building in a vanilla monorepo layout.
2. Make sure you use one of the documented ways to build the runtimes: https://libcxx.llvm.org/BuildingLibcxx.html

If you don't do that, LLVM 15 is going to break you, and we will not revert that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88458/new/

https://reviews.llvm.org/D88458