[libcxx-commits] [PATCH] D114761: [libc++][ranges] Implement [special.mem.concepts].
Konstantin Varlamov via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Nov 30 14:50:23 PST 2021
var-const marked an inline comment as done.
var-const added inline comments.
================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.input/input_iterator.compile.pass.cpp:110-116
- bad_iterator_concept() = default;
-
- bad_iterator_concept(bad_iterator_concept&&) = default;
- bad_iterator_concept& operator=(bad_iterator_concept&&) = default;
-
- bad_iterator_concept(bad_iterator_concept const&) = delete;
- bad_iterator_concept& operator=(bad_iterator_concept const&) = delete;
----------------
Quuxplusone wrote:
> Feel free to delete lines 110–116, and remove all the blank lines in this class body. That'll help shorten things up, without metaprogramming.
> Ditto lines 89–97 and 69–77 and 50–58.
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114761/new/
https://reviews.llvm.org/D114761
More information about the libcxx-commits
mailing list