[libcxx-commits] [PATCH] D114818: [libunwind] Fix unwind_leaffunction test

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D114818#3162491 <https://reviews.llvm.org/D114818#3162491>, @leonardchan wrote:

> I haven't yet responded on D114385 <https://reviews.llvm.org/D114385>, but it looks like using `__builtin_trap()` still breaks the test for us because the unwinder doesn't iterate over the frame for `main`. Instead it goes from `crashing_leaf_func` to `__libc_start_main`, then runs out of frames. I'm still investigating why it does this. I don't think that should be a blocker for landing this though since this approach seems more correct than the `raise`, so LGTM.

Thanks for chiming in. I'll wait for the CI to be green and ship this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114818/new/

https://reviews.llvm.org/D114818