[libcxx-commits] [PATCH] D110494: [libc++][format][1/6] Reduce binary size.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM but I am a bit concerned by the use of `_LIBCPP_ALWAYS_INLINE`. Normally, I would expect the compiler to do the right thing.

This seems reasonable to me since we are applying it systematically on functions that are thin wrappers around `__vformat_to`, which contains the real meat of the implementation and is not marked as `_LIBCPP_ALWAYS_INLINE`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110494/new/

https://reviews.llvm.org/D110494