[libcxx-commits] [PATCH] D114658: [libc++] [test] Refactor string_view comparison tests for comprehensiveness.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 30 13:17:57 PST 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/less_equal.pass.cpp:45
+    };
+    for (int i=0; i < 4; ++i) {
+        for (int j=0; j < 4; ++j) {
----------------
Here and in other places -- this is unusual.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114658/new/

https://reviews.llvm.org/D114658



More information about the libcxx-commits mailing list