[libcxx-commits] [PATCH] D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D114129#3162314 <https://reviews.llvm.org/D114129#3162314>, @fwolff wrote:

> In D114129#3158805 <https://reviews.llvm.org/D114129#3158805>, @Mordante wrote:
>
>> I prefer to allow this extension; I even wonder whether not allowing 128-bit values was intentionally or an artifact of prohibiting `(un)signed char`. In general I prefer to allow `__[u]int128_t` to be used as a first-class citizen in libc++.
>
> Yes, this is also how I feel about this.

Ok. In that case, can we add a comment somewhere in `uniform_int_distribution` that `__int128_t` is supported? Make sure the comment contains the word "extension", so that when we eventually get a formal way of documenting those, it's easy to find the existing extensions we support.

> In D114129#3158555 <https://reviews.llvm.org/D114129#3158555>, @ldionne wrote:
>
>> [...] or provide this as an extension (in which case we should probably annotate that it is an extension).
>
> What does that mean exactly, annotating it as an extension?

I just meant documenting it somewhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114129/new/

https://reviews.llvm.org/D114129