[libcxx-commits] [PATCH] D112976: [libc++][NFC] Inline most of `__vector_base` into `vector`.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D112976#3122551 <https://reviews.llvm.org/D112976#3122551>, @shafik wrote:

> Hello,
>
> Just a reminder when we change underlying structure of types in libc++ it is important to run the LLDB test suite. We have many formatters for libc++ and the rely on a lot of internals for the formatting. This case did not break a formatter it did change the type being returned by several member functions.
>
> I had to track down this break using bisect and I just applied a fix: 0d62e31c458526e1db37d11da947e61768c7b522 <https://reviews.llvm.org/rG0d62e31c458526e1db37d11da947e61768c7b522>

We have to find a solution for this. Depending on what you mean by the "structure" of things, I suspect we are changing that all the time.

How long does it take to run the LLDB formatters? Could we add a CI job that does exactly that? If we don't implement a systematic way of catching these bugs, we will keep breaking you without intending to. Can you provide a minimal CMake + Lit invocation to run the LLDB formatters (and ideally just that to save time)? I'll look into adding a CI job for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112976/new/

https://reviews.llvm.org/D112976