[libcxx-commits] [PATCH] D114385: [libunwind] Fix testing with sanitizers enabled

Daniel Kiss via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 30 01:07:01 PST 2021


danielkiss added inline comments.


================
Comment at: libunwind/test/unwind_leaffunction.pass.cpp:41-43
 __attribute__((noinline)) void crashing_leaf_func(void) {
-  *faultyPointer = 0;
+  raise(SIGSEGV);
 }
----------------
adding a call here turns the leaf function into a not-leaf function which changes the intention of this test.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114385/new/

https://reviews.llvm.org/D114385



More information about the libcxx-commits mailing list