[libcxx-commits] [PATCH] D109459: [libc++][ABI BREAK] Do not use the C++03 emulation for std::nullptr_t by default

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

FWIW, I like this idea.



================
Comment at: libcxx/docs/ReleaseNotes.rst:102-111
+- The C++03 emulation type for ``std::nullptr_t`` has been removed in favour of
+  using ``decltype(nullptr)`` in all Standard modes. This is an ABI break for
+  anyone compiling in C++03 mode and who has ``std::nullptr_t`` as part of their
+  ABI. However, previously, these user's ABI would be incompatible with any other
+  binary or static archive compiled with C++11 or later. If you start seeing linking
+  errors involving ``std::nullptr_t`` against previously compiled binaries, this may
+  be the cause. You can define the ``_LIBCPP_ABI_USE_CXX03_NULLPTR_EMULATION`` macro
----------------
s/favour/favor/
s/Standard modes/standard modes/ ?
s/these user's/these users'/
s/linking/linker/ ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109459/new/

https://reviews.llvm.org/D109459