[libcxx-commits] [PATCH] D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 28 09:25:50 PST 2021


Quuxplusone accepted this revision.
Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.int/int128.pass.cpp:29
+  {
+    auto e = std::minstd_rand0{};
+    auto d = std::uniform_int_distribution<__int128_t>{};
----------------
Mordante wrote:
> Please change `auto` with the type, here and in the remainder of this file. This is the typical style in LLVM/libc++.
(FWIW, as long as it's `auto x = TheSpecificType();` as in these cases, personally I'm fine with it. But even in these cases, `TheSpecificType x;` will be shorter.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114129/new/

https://reviews.llvm.org/D114129



More information about the libcxx-commits mailing list