[libcxx-commits] [PATCH] D114658: [WIP] [libc++] [test] Several test-code refactorings.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Nice cleanup. I see quite a bit of repetition in the tests, but I don't see a simple way to avoid that.



================
Comment at: libcxx/test/support/test_macros.h:153
+# else
+#  define TEST_IS_RUNTIME_OR_CXX20 (!__builtin_is_constant_evaluated())
+# endif
----------------
As you already mentioned in your commit message these are unused and don't look too pretty. I would prefer to not add them until we really need them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114658/new/

https://reviews.llvm.org/D114658