[libcxx-commits] [PATCH] D114658: [WIP] [libc++] [test] Several test-code refactorings.
Joe Loser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Nov 26 17:58:17 PST 2021
jloser added inline comments.
================
Comment at: libcxx/test/std/strings/string.view/string.view.comparison/opeq.pass.cpp:49-52
+ assert((v[i].data() == v[j]) == expected);
+ assert((v[i] == v[j].data()) == expected);
+ assert((ConvertibleTo<SV>(v[i]) == v[j]) == expected);
+ assert((v[i] == ConvertibleTo<SV>(v[j])) == expected);
----------------
Quuxplusone wrote:
> I expected these to fail-to-compile on clang-cl, for the reasons discussed (at length!) in D113161; but it didn't fail, at least not on buildkite. Strange.
Any ideas why it doesn't fail on `clang-cl` on buildkit?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114658/new/
https://reviews.llvm.org/D114658
More information about the libcxx-commits
mailing list