[libcxx-commits] [PATCH] D114129: [libc++] Fix `uniform_int_distribution` for 128-bit result type

Fabian Wolff via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 25 16:46:34 PST 2021


fwolff marked 8 inline comments as done.
fwolff added inline comments.


================
Comment at: libcxx/include/__random/log2.h:23
+template <class _UIntType, _UIntType _Xp, size_t _Rp>
+struct __log2_imp;
+
----------------
Mordante wrote:
> Does this header the same as `__bit_log2` in `<bit>`?
Yes, but `__bit_log2` is marked with `_LIBCPP_CONSTEXPR_AFTER_CXX11`, so it won't work for C++11 because we are using it to initialize `static const` members, or am I missing something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114129/new/

https://reviews.llvm.org/D114129



More information about the libcxx-commits mailing list