[libcxx-commits] [PATCH] D113161: [libc++] Implement P1989R2: range constructor for string_view

[Joe Loser via Phabricator via libcxx-commits]

jloser marked 3 inline comments as done.
jloser added inline comments.


================
Comment at: libcxx/test/std/strings/string.view/string.view.cons/from_range.pass.cpp:127
+
+int main(int, char**) {
+  test();
----------------
jloser wrote:
> Mordante wrote:
> > The paper has a Thows clause `Throws:Any exception thrown byranges::data(r)andranges::size(r).`
> > Can you add some tests to verify that behaviour?
> Should be doable - good idea. I'll look into that once I figure out the duplicate symbol issue for windows-dll for `std::string_view::operator!=`. My attempted fix using `__type_identity_t` doesn't work.
Added some tests for both cases! Clang doesn't like `throws` in a `constexpr` member function like `size()` or `data()`, so they're just a normal runtime test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113161/new/

https://reviews.llvm.org/D113161