[libcxx-commits] [PATCH] D113161: [libc++] Implement P1989R2: range constructor for string_view

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/include/filesystem:1036
     if (__p.is_absolute() ||
-        (!__p_root_name.empty() && __p_root_name != root_name())) {
+        (!__p_root_name.empty() && __p_root_name != __string_view(root_name().__pn_))) {
       __pn_ = __p.__pn_;
----------------
@Quuxplusone I'm trying to explicitly create the `string_view` now here which may just dance around the `windows-dll` issue since we won't try to instantiate the `operator!=` overload where the RHS is convertible to `string_view` - we just stick with `operator!=(std::string_view, std::string_view)` overload exclusively. But it's still a problem for another patch probably. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113161/new/

https://reviews.llvm.org/D113161