[libcxx-commits] [PATCH] D114561: [libc++] Fix constraints for string_view's iterator/sentinel constructor

Wed Nov 24 13:02:56 PST 2021

jloser marked an inline comment as done.
jloser added inline comments.

================
Comment at: libcxx/include/string_view:194-195

 #include <__concepts/convertible_to.h>
 #include <__concepts/same_as.h>
 #include <__config>
----------------
Quuxplusone wrote:
> Please check whether we can remove either/both of these headers now.
I removed them and it should be fine since they were only added in 4be7f48960980831a9b744c96f38ddb7dc7848ce when I implemented the iterator/sentinel constructor. Nobody else is using them in this file.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114561/new/

https://reviews.llvm.org/D114561