[libcxx-commits] [PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

Momchil Velikov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 24 04:44:41 PST 2021


chill added inline comments.


================
Comment at: libunwind/src/Unwind-EHABI.cpp:312
               uint8_t registers = getByte(data, offset++);
-              if (registers & 0xf0 || !registers)
+              if (registers & 0xf0)
                 return _URC_FAILURE;
----------------
mstorsjo wrote:
> This particular change looks unrelated to the rest, on a quick glance
Indeed, that change is a leftover from when the encoding of the instruction to pop return address authentication code was `<0xb1,0x00>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112430/new/

https://reviews.llvm.org/D112430



More information about the libcxx-commits mailing list